[RFC 18/18] drivers/net: add hinic3 PMD build and doc files

Stephen Hemminger stephen at networkplumber.org
Fri Apr 18 19:22:30 CEST 2025


On Fri, 18 Apr 2025 17:06:04 +0800
Feifei Wang <wff_light at vip.163.com> wrote:

> +cflags += [
> +    '-DHW_CONVERT_ENDIAN',
> +    '-D__HINIC_HUAWEI_SECUREC__',
> +    '-fPIC',
> +    '-fstack-protector-strong',
> +]

What is this?
Should not enable PIC or stack-protector at the driver level.
I assume the other stuff is huawei specific compiler flags.

> +if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
> +    cflags += ['-D__ARM64_NEON__']
> +else
> +    cflags += ['-D__X86_64_SSE__']
> +endif


This should already be handled in the existing DPDK meson stuff.
Doing it at a per-driver level seems wrong.


More information about the dev mailing list