[PATCH 2/5] net/qede: fix bad sanity check on Rx queue release
Stephen Hemminger
stephen at networkplumber.org
Wed Apr 23 17:30:52 CEST 2025
On Tue, 22 Apr 2025 17:51:40 +0200
edwin.brossette at 6wind.com wrote:
> From: Edwin Brossette <edwin.brossette at 6wind.com>
>
> As per the rte_mbuf API: the driver is responsible of initializing all
> the required fields. This is not done at qede alloc, meaning there can
> be garbage data in mbufs memory, although this garbage data should be
> overwritten when the mbufs are used. Since a sanity check is done when
> freeing the queues, its possible some remaining garbage data causes a
> panic when trying to release the queues if some mbufs are being
> processed.
>
> Use rte_pktmbuf_raw_free() instead of rte_pktmbuf_free() as the sanity
> check is more relaxed.
>
> Fixes: 2ea6f76aff40 ("qede: add core driver")
> CC: stable at dpdk.org
Patch looks fine, but DPDK is trying to follow the inclusive naming
guidelines. The term "sanity check" is on the not allowed list.
I will reword the commit message.
https://inclusivenaming.org/word-lists/tier-2/sanity-check/
More information about the dev
mailing list