[PATCH] dpdk: support quick jump to API definition
fengchengwen
fengchengwen at huawei.com
Fri Aug 29 03:31:30 CEST 2025
On 8/28/2025 10:47 PM, Stephen Hemminger wrote:
> On Thu, 28 Aug 2025 10:46:31 +0800
> Chengwen Feng <fengchengwen at huawei.com> wrote:
>
>> Currently, the RTE_EXPORT_INTERNAL_SYMBOL, RTE_EXPORT_SYMBOL and
>> RTE_EXPORT_EXPERIMENTAL_SYMBOL are placed at the beginning of APIs,
>> but don't end with a semicolon. As a result, some IDEs cannot identify
>> the APIs and cannot quickly jump to the definition.
>>
>> A semicolon is added to the end of above RTE_EXPORT_XXX_SYMBOL in this
>> commit.
>>
>> And also change the gen-version-map.py to ensure it only identifies
>> RTE_EXPORT_XXX_SYMBOL that end with a semicolon.
>>
>> Signed
>
> Semicolon after macro will cause scripts like checkpatch to complain?
No
This commit trigger a checkpatch error because the following function add two semicolon.
RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_node_mbuf_dynfield_register, 25.07);;
Because the RTE_EXPORT_XXX_SYMBOL(XXX) macro do nothing, and this macro are placed out side
of function, it will left one semicolon after pre-process. This is not strictly comply with
C stand syntax.
In the V2 I will adopt following:
1\ #define RTE_EXPORT_XXX_SYMBOL(XXX) extern int __dummy_unused__ , this definition is comply
with C stand syntax.
2\ keep the gen-version-map.py un-touch, because some commit are in-process different branch.
Thanks.
More information about the dev
mailing list