[PATCH v3] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch
Andre Muezerie
andremue at linux.microsoft.com
Wed Feb 5 20:38:27 CET 2025
On Wed, Feb 05, 2025 at 10:35:25AM -0800, Stephen Hemminger wrote:
> On Tue, 14 Jan 2025 13:05:02 -0800
> Andre Muezerie <andremue at linux.microsoft.com> wrote:
>
> > This patch avoids warnings like the ones below emitted by MSVC:
> >
> > 1)
> > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> > result of 32-bit shift implicitly converted to 64 bits
> > (was 64-bit shift intended?)
> >
> > 2)
> > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> > signed/unsigned mismatch
> >
> > The fix for (1) is to use 64-bit shifting when appropriate
> > (according to what the result is used for).
> >
> > The fix for (2) is to explicitly cast the variables used in the
> > comparison.
> >
> > Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>
> > ---
>
> Needs rebase, the Intel drivers got reorganized.
Thanks for letting me know. I rebased and sent out the updated patch.
More information about the dev
mailing list