[PATCH v7 04/15] net/xsc: add xsc dev ops to support VFIO driver
Renyong Wan
wanry at yunsilicon.com
Thu Feb 6 10:28:42 CET 2025
On 2025/2/6 0:54, David Marchand wrote:
>> No, it won't probe twice.
>> I suppose that each PCI device will only be bound to either the VFIO
>> driver or a kernel driver. The drv_flags of the xsc_pmd PCI driver will
>> not preset with RTE_PCI_DRV_NEED_MAPPING. Therefore, in the
>> rte_pci_probe_one_driver function, rte_pci_map_device() will not be
>> called. After entering the probe phase of the xsc PMD PCI driver,
>> rte_pci_map_device() will be called in xsc_dev_ops->init() based on
>> whether it is a VFIO driver.
> (side note, this means that this driver should probably call
> rte_pci_unmap_device() in its release path, though I see none)
Hello David,
You're absolutely right, thank you very much for the notice, it does
seem like an oversight that rte_pci_unmap_device() is missing in the
driver's release path, I will fix it in the next submission.
--
Best regards,
Renyong Wan
More information about the dev
mailing list