Re: [PATCH] vhost: fix VDUSE devices registration

[Ariel Otilibili-Anieli]

Hi Maxime,

On Wednesday, February 05, 2025 22:18 CET, Maxime Coquelin <maxime.coquelin at redhat.com> wrote:

> Hi Ariel,
> 
> 
> Not really :)
> Without your patch, ret was assigned by the pthread_mutex_init() return,
> so always 0. With your patch, this assignment is removed so ret will
> always be -1 for VDUSE devices.
> 
> So before your patch, VDUSE devices registration was functional, with
> your patch it breaks systematically.
> 
> We don't want to backport my patch to LTS that aren't imapcted, so
> tagging your patch as the one introducing the regression is the right
> thing to do.

:) Gotcha; it is now clearer to me.
> 
> > :) For my understanding; now that 4d2aa150769b ("vhost: remove check around mutex init") needs a fix, is there a way by which I could have detect the regression?
> 
> It could have been detected by testing VDUSE, that's how I noticed it.
> But VDUSE is still fairly recent, and it is not yet tested by the CI.
> 
> Now that it is supported in at least Fedora without any kernel change,
> we should work on adding CI testing for it.
> 
> > Your help will be much appreciated,
> > Ariel
> > 
> 
> Thanks for your contribution,
> Maxime

Thanks for having put some of your time into the explanation. 

Have a good day,
Ariel
>