[PATCH v2 1/6] ethdev: check that device supports deferred start
Stephen Hemminger
stephen at networkplumber.org
Fri Feb 14 18:38:54 CET 2025
The check for supporting deferred start should be handled at
the ethdev level for all devices.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
lib/ethdev/rte_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index c4079bb924..5493b3b9f8 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -2274,6 +2274,13 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
if (rx_conf != NULL)
rx_offloads |= rx_conf->offloads;
+ /* Deferred start requires that device supports queue start */
+ if (rx_conf && rx_conf->rx_deferred_start && *dev->dev_ops->rx_queue_start == NULL) {
+ RTE_ETHDEV_LOG_LINE(ERR,
+ "Deferred start requested, but driver does not support Rx queue start");
+ return -ENOTSUP;
+ }
+
/* Ensure that we have one and only one source of Rx buffers */
if ((mp != NULL) +
(rx_conf != NULL && rx_conf->rx_nseg > 0) +
@@ -2585,6 +2592,13 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
return -EINVAL;
}
+ /* Deferred start requires that device supports queue start */
+ if (tx_conf && tx_conf->tx_deferred_start && *dev->dev_ops->tx_queue_start == NULL) {
+ RTE_ETHDEV_LOG_LINE(ERR,
+ "Deferred start requested, but driver does not support Tx queue start");
+ return -ENOTSUP;
+ }
+
ret = rte_eth_dev_info_get(port_id, &dev_info);
if (ret != 0)
return ret;
--
2.47.2
More information about the dev
mailing list