[PATCH v3 00/14] Remove unnecessary function pointer deref
Stephen Hemminger
stephen at networkplumber.org
Thu Feb 20 17:55:14 CET 2025
A common pattern in DPDK internals is to have an array of function
pointers. When using these pointers an unnecessary derefence is done;
this is allowed in C because of a historical quirk but unnecessary.
This fixes all instances of PVS Studio checker warning:
https://pvs-studio.com/en/docs/warnings/v516/
This leads to a large number of warnings marked as High severity.
This patchset simplifies the source and gets rid of these warnings.
v3 - remove unnecessary paren in ethdev ip_reassembly capability
Stephen Hemminger (14):
ethdev: remove unnecessary deref on function pointers
eventdev: remover unnecessary deref on function pointers
net/bonding: remove unnecessary deref of function pointers
net/ixgbe: remove unnecessary dereference
net/ipn3ke: remove unnecessary dereference
net/memif: remove unnecessary deref of function pointers
cryptodev: remove unnecessary deref of function pointers
crypto/scheduler: remove unnecessary dereference
compressdev: remove unnecessary deref of function pointers
dmadev: remove unnecessary deref of function pointers
rawdev: remove unnecessary deref of function pointers
mldev: remove unnecessary deref of function pointers
regexdev: remove unnecessary deref of function pointers
security: remove unnecessary dereference
.../scheduler/rte_cryptodev_scheduler.c | 8 +-
drivers/crypto/scheduler/scheduler_pmd_ops.c | 25 +-
drivers/net/bonding/rte_eth_bond_pmd.c | 12 +-
drivers/net/intel/ipn3ke/ipn3ke_ethdev.c | 27 +-
drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 +-
drivers/net/memif/rte_eth_memif.c | 6 +-
lib/compressdev/rte_compressdev.c | 56 +-
lib/cryptodev/rte_cryptodev.c | 72 ++-
lib/dmadev/rte_dmadev.c | 38 +-
lib/ethdev/ethdev_driver.c | 16 +-
lib/ethdev/ethdev_private.c | 4 +-
lib/ethdev/rte_ethdev.c | 494 ++++++++----------
lib/ethdev/rte_ethdev.h | 12 +-
lib/ethdev/rte_ethdev_cman.c | 8 +-
lib/eventdev/rte_event_crypto_adapter.c | 37 +-
lib/eventdev/rte_event_dma_adapter.c | 16 +-
lib/eventdev/rte_event_eth_rx_adapter.c | 50 +-
lib/eventdev/rte_eventdev.c | 164 +++---
lib/mldev/rte_mldev.c | 88 ++--
lib/rawdev/rte_rawdev.c | 99 ++--
lib/regexdev/rte_regexdev.c | 72 +--
lib/security/rte_security.c | 5 +-
22 files changed, 613 insertions(+), 701 deletions(-)
--
2.47.2
More information about the dev
mailing list