[RFC 4/5] net/zxdh: make callback table const and static
Stephen Hemminger
stephen at networkplumber.org
Sun Feb 23 03:42:23 CET 2025
Tables of function pointers should be const, and since only used
in one file can be marked static.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/zxdh/zxdh_msg.c | 2 +-
drivers/net/zxdh/zxdh_msg.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/zxdh/zxdh_msg.c b/drivers/net/zxdh/zxdh_msg.c
index 4cd58ca0cb..ca614d43d9 100644
--- a/drivers/net/zxdh/zxdh_msg.c
+++ b/drivers/net/zxdh/zxdh_msg.c
@@ -2055,7 +2055,7 @@ zxdh_vf_mtr_hw_profile_cfg(struct zxdh_hw *pf_hw __rte_unused,
return 0;
}
-zxdh_msg_process_callback zxdh_proc_cb[] = {
+static const zxdh_msg_process_callback zxdh_proc_cb[] = {
[ZXDH_NULL] = NULL,
[ZXDH_VF_PORT_INIT] = zxdh_vf_port_init,
[ZXDH_VF_PORT_UNINIT] = zxdh_vf_port_uninit,
diff --git a/drivers/net/zxdh/zxdh_msg.h b/drivers/net/zxdh/zxdh_msg.h
index f82995bf0b..58836bb4b7 100644
--- a/drivers/net/zxdh/zxdh_msg.h
+++ b/drivers/net/zxdh/zxdh_msg.h
@@ -527,7 +527,6 @@ typedef int (*zxdh_bar_chan_msg_recv_callback)(void *pay_load, uint16_t len,
void *reps_buffer, uint16_t *reps_len, void *dev);
typedef int (*zxdh_msg_process_callback)(struct zxdh_hw *hw, uint16_t vport, void *cfg_data,
struct zxdh_msg_reply_body *res_info, uint16_t *res_len);
-extern zxdh_msg_process_callback zxdh_proc_cb[];
typedef int (*zxdh_bar_chan_msg_recv_callback)(void *pay_load, uint16_t len,
void *reps_buffer, uint16_t *reps_len, void *dev);
--
2.47.2
More information about the dev
mailing list