[PATCH V2 4/4] net/mlx5/hws: allow different types in miss validation
Ophir Munk
ophirmu at nvidia.com
Wed Feb 26 09:38:46 CET 2025
In validating Jump from group A to default miss group B DPDK requests
that both groups types will be identical. In practice jumping from
FDB_UNIFIED to FDB_RX or FDB_TX group types (or vice versa) is allowed.
This commit enables this jumping between the different types.
Fixes: b81f95ca770d ("net/mlx5/hws: support default miss table")
Signed-off-by: Ophir Munk <ophirmu at nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_table.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c
index b371f42..c1c60b4 100644
--- a/drivers/net/mlx5/hws/mlx5dr_table.c
+++ b/drivers/net/mlx5/hws/mlx5dr_table.c
@@ -626,6 +626,19 @@ int mlx5dr_table_connect_to_miss_table(struct mlx5dr_table *src_tbl,
return 0;
}
+static bool mlx5dr_table_set_default_miss_valid_types(enum mlx5dr_table_type from,
+ enum mlx5dr_table_type to)
+{
+ if (from == to ||
+ ((from == MLX5DR_TABLE_TYPE_FDB_UNIFIED &&
+ (to == MLX5DR_TABLE_TYPE_FDB_RX || to == MLX5DR_TABLE_TYPE_FDB_TX)) ||
+ (to == MLX5DR_TABLE_TYPE_FDB_UNIFIED &&
+ (from == MLX5DR_TABLE_TYPE_FDB_RX || from == MLX5DR_TABLE_TYPE_FDB_TX))))
+ return true;
+
+ return false;
+}
+
static int mlx5dr_table_set_default_miss_not_valid(struct mlx5dr_table *tbl,
struct mlx5dr_table *miss_tbl)
{
@@ -637,8 +650,9 @@ static int mlx5dr_table_set_default_miss_not_valid(struct mlx5dr_table *tbl,
}
if (mlx5dr_table_is_root(tbl) ||
- (miss_tbl && mlx5dr_table_is_root(miss_tbl)) ||
- (miss_tbl && miss_tbl->type != tbl->type)) {
+ (miss_tbl &&
+ ((mlx5dr_table_is_root(miss_tbl)) ||
+ !mlx5dr_table_set_default_miss_valid_types(tbl->type, miss_tbl->type)))) {
DR_LOG(ERR, "Invalid arguments");
rte_errno = EINVAL;
return -rte_errno;
--
2.8.4
More information about the dev
mailing list