[EXTERNAL] Re: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing

[Tomasz Duszynski]

>> From: Tomasz Duszynski <tduszynski at marvell.com>
>> To: <dev at dpdk.org>, Stephen Hemminger <stephen at networkplumber.org>,
>"Pascal  Mazon" <pascal.mazon at 6wind.com>
>> CC: <jerinj at marvell.com>, Tomasz Duszynski <tduszynski at marvell.com>
>> Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is
>> missing
>> Date: Wed, 8 Jan 2025 13:10:11 +0100
>> X-Mailer: git-send-email 2.34.1
>>
>> If HAVE_TCA_FLOWER is undefined compilation errors / warnings may
>> appear. This addresses following spotted issues:
>>
>> ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’
>> defined but not used [-Werror=unused-label]
>>
>> ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter
>> ‘remote_iface’ [-Werror=unused-parameter]
>>
>> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
>> Cc: pascal.mazon at 6wind.com
>>
>> Signed-off-by: Tomasz Duszynski <tduszynski at marvell.com>
>
>Looks good, but realize that flower was added in kernel 4.2 and the current
>oldest supported upstream kernel is 4.4.
>So if you are using a supported kernel, flower will be present.

It only pops up on 32bit build. That build is maybe not too common so error might have
gone unnoticed. Anyway, I thought I would add these fixes just in case.