[PATCH 4/6] net/failsafe: remove check around pthread_mutex_init()

Ariel Otilibili otilibil at eurecom.fr
Sun Jan 12 19:58:40 CET 2025


> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.

Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
 drivers/net/failsafe/failsafe.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 32811403b4c8..e1c77cdf4fd1 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -147,11 +147,7 @@ fs_mutex_init(struct fs_priv *priv)
 		ERROR("Cannot set mutex type - %s", strerror(ret));
 		return ret;
 	}
-	ret = pthread_mutex_init(&priv->hotplug_mutex, &attr);
-	if (ret) {
-		ERROR("Cannot initiate mutex - %s", strerror(ret));
-		return ret;
-	}
+	pthread_mutex_init(&priv->hotplug_mutex, &attr);
 	return 0;
 }
 
-- 
2.30.2



More information about the dev mailing list