[PATCH v3 3/6] common/cnxk: remove check around pthread_mutex_init()
Ariel Otilibili
otilibil at eurecom.fr
Sun Jan 12 21:20:18 CET 2025
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
---
drivers/common/cnxk/roc_bphy_cgx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/common/cnxk/roc_bphy_cgx.c b/drivers/common/cnxk/roc_bphy_cgx.c
index 4f43605e1031..882cf654743b 100644
--- a/drivers/common/cnxk/roc_bphy_cgx.c
+++ b/drivers/common/cnxk/roc_bphy_cgx.c
@@ -189,14 +189,11 @@ int
roc_bphy_cgx_dev_init(struct roc_bphy_cgx *roc_cgx)
{
uint64_t val;
- int ret;
if (!roc_cgx || !roc_cgx->bar0_va || !roc_cgx->bar0_pa)
return -EINVAL;
- ret = pthread_mutex_init(&roc_cgx->lock, NULL);
- if (ret)
- return ret;
+ pthread_mutex_init(&roc_cgx->lock, NULL);
val = roc_bphy_cgx_read(roc_cgx, 0, CGX_CMRX_RX_LMACS);
val = FIELD_GET(CGX_CMRX_RX_LMACS_LMACS, val);
--
2.30.2
More information about the dev
mailing list