[PATCH v14 03/81] eal/common: remove use of VLAs

[Andre Muezerie]

On Mon, Jan 13, 2025 at 01:30:12PM -0800, Andre Muezerie wrote:
> On Fri, Jan 10, 2025 at 05:14:05PM -0800, Stephen Hemminger wrote:
> > On Fri, 10 Jan 2025 12:22:22 -0800
> > Andre Muezerie <andremue at linux.microsoft.com> wrote:
> > 
> > > diff --git a/lib/eal/meson.build b/lib/eal/meson.build
> > > index e1d6c4cf17..352db049e9 100644
> > > --- a/lib/eal/meson.build
> > > +++ b/lib/eal/meson.build
> > > @@ -31,3 +31,11 @@ endif
> > >  if is_freebsd
> > >      annotate_locks = false
> > >  endif
> > > +
> > > +warning_flags = ['-Wvla']
> > > +
> > > +foreach arg: warning_flags
> > > +    if cc.has_argument(arg)
> > > +        cflags += arg
> > > +    endif
> > > +endforeach
> > > -- 
> > 
> > Could we enable it for all libs and only turn it off as required?
> 
> Yes. Although the data types in meson are additive only, we can
> add -Wno-vla to cancel a -Wvla already present. Let me send out a
> new series with this change.

Series v16 has the changes proposed.

There was only one failure reported now, which seems infra-related:
"The requested resource was not found on this server":
https://mails.dpdk.org/archives/test-report/2025-January/842300.html

Let me know if any action is needed from my side.

Thanks,

Andre Muezerie