Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Ariel Otilibili-Anieli]

Hello Stephen,

On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger <stephen at networkplumber.org> wrote:

> On Fri, 13 Dec 2024 22:41:55 +0100
> Ariel Otilibili <otilibil at eurecom.fr> wrote:
> 
> > Coverity issue: 384444
> > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Cc: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> > Cc: stable at dpdk.org
> > Signed-off-by: Ariel Otilibili <otilibil at eurecom.fr>
> > ---
> 
> This gets checkpatch warning when I merged the SHA value is not correct.
> 
> ### [PATCH] net/sfc: remove unused value
> 
> WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")'
>

Thanks for the heads up; I'll set the correct length in my .gitconfig
> Bad
>  Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> Good
>  Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Have a good one,
Ariel