[PATCH v5 01/15] net/xsc: add xsc PMD framework

WanRenyong wanry at yunsilicon.com
Fri Jan 17 04:29:11 CET 2025


On 2025/1/17 2:18, Stephen Hemminger wrote:
> On Tue, 07 Jan 2025 10:49:40 +0800
> "WanRenyong" <wanry at yunsilicon.com> wrote:
>
>> diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
>> new file mode 100644
>> index 0000000000..a7dca46127
>> --- /dev/null
>> +++ b/drivers/net/xsc/xsc_ethdev.c
>> @@ -0,0 +1,89 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright 2025 Yunsilicon Technology Co., Ltd.
>> + */
>> +
>> +#include <net/if.h>
> Why are you including this file (it relates to Linux networking not DPDK)?
> If I remove it build works fine.
>
Thank you for your review. This is codeleftoverfrom early patches that 
had dependencies on kernel drivers. I will remove it next time.

By the way, is there any new incoming review feedback about this patch 
series? If not, I will address current review comments and resubmit the 
new revised version of the patches.

-- 
Thanks,
WanRenyong


More information about the dev mailing list