[PATCH 01/15] fib: add allocation function attributes
Stephen Hemminger
stephen at networkplumber.org
Mon Jan 20 19:03:19 CET 2025
Use function attributes to catch cases where fib table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
lib/fib/rte_fib.h | 26 +++++++++++++++-----------
lib/fib/rte_fib6.h | 24 +++++++++++++-----------
lib/fib/trie.h | 7 ++++---
3 files changed, 32 insertions(+), 25 deletions(-)
diff --git a/lib/fib/rte_fib.h b/lib/fib/rte_fib.h
index 496d137d48..65c24d5459 100644
--- a/lib/fib/rte_fib.h
+++ b/lib/fib/rte_fib.h
@@ -17,8 +17,10 @@
#include <stdint.h>
+#include <rte_common.h>
#include <rte_rcu_qsbr.h>
+
#ifdef __cplusplus
extern "C" {
#endif
@@ -128,6 +130,17 @@ struct rte_fib_rcu_config {
uint32_t reclaim_max;
};
+
+/**
+ * Free an FIB object.
+ *
+ * @param fib
+ * FIB object handle created by rte_fib_create().
+ * If fib is NULL, no operation is performed.
+ */
+void
+rte_fib_free(struct rte_fib *fib);
+
/**
* Create FIB
*
@@ -142,7 +155,8 @@ struct rte_fib_rcu_config {
* NULL otherwise with rte_errno set to an appropriate values.
*/
struct rte_fib *
-rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf);
+rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf)
+ __rte_malloc __rte_dealloc(rte_fib_free, 1);
/**
* Find an existing FIB object and return a pointer to it.
@@ -157,16 +171,6 @@ rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf);
struct rte_fib *
rte_fib_find_existing(const char *name);
-/**
- * Free an FIB object.
- *
- * @param fib
- * FIB object handle created by rte_fib_create().
- * If fib is NULL, no operation is performed.
- */
-void
-rte_fib_free(struct rte_fib *fib);
-
/**
* Add a route to the FIB.
*
diff --git a/lib/fib/rte_fib6.h b/lib/fib/rte_fib6.h
index 21f0492374..b03b24421c 100644
--- a/lib/fib/rte_fib6.h
+++ b/lib/fib/rte_fib6.h
@@ -82,6 +82,17 @@ struct rte_fib6_conf {
};
};
+
+/**
+ * Free an FIB object.
+ *
+ * @param fib
+ * FIB object handle created by rte_fib6_create().
+ * If fib is NULL, no operation is performed.
+ */
+void
+rte_fib6_free(struct rte_fib6 *fib);
+
/**
* Create FIB
*
@@ -96,7 +107,8 @@ struct rte_fib6_conf {
* NULL otherwise with rte_errno set to an appropriate values.
*/
struct rte_fib6 *
-rte_fib6_create(const char *name, int socket_id, struct rte_fib6_conf *conf);
+rte_fib6_create(const char *name, int socket_id, struct rte_fib6_conf *conf)
+ __rte_malloc __rte_dealloc(rte_fib6_free, 1);
/**
* Find an existing FIB object and return a pointer to it.
@@ -111,16 +123,6 @@ rte_fib6_create(const char *name, int socket_id, struct rte_fib6_conf *conf);
struct rte_fib6 *
rte_fib6_find_existing(const char *name);
-/**
- * Free an FIB object.
- *
- * @param fib
- * FIB object handle created by rte_fib6_create().
- * If fib is NULL, no operation is performed.
- */
-void
-rte_fib6_free(struct rte_fib6 *fib);
-
/**
* Add a route to the FIB.
*
diff --git a/lib/fib/trie.h b/lib/fib/trie.h
index f87fc0f6d2..bcb161702b 100644
--- a/lib/fib/trie.h
+++ b/lib/fib/trie.h
@@ -129,12 +129,13 @@ LOOKUP_FUNC(2b, uint16_t, 1)
LOOKUP_FUNC(4b, uint32_t, 2)
LOOKUP_FUNC(8b, uint64_t, 3)
-void *
-trie_create(const char *name, int socket_id, struct rte_fib6_conf *conf);
-
void
trie_free(void *p);
+void *
+trie_create(const char *name, int socket_id, struct rte_fib6_conf *conf)
+ __rte_malloc __rte_dealloc(trie_free, 1);
+
rte_fib6_lookup_fn_t
trie_get_lookup_fn(void *p, enum rte_fib6_lookup_type type);
--
2.45.2
More information about the dev
mailing list