[PATCH 05/15] pipeline: add allocation function attributes
Stephen Hemminger
stephen at networkplumber.org
Mon Jan 20 19:03:23 CET 2025
Use function attributes to catch cases where pipeline is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
lib/pipeline/rte_port_in_action.h | 55 ++++++++++++++++---------------
lib/pipeline/rte_table_action.h | 53 +++++++++++++++--------------
2 files changed, 56 insertions(+), 52 deletions(-)
diff --git a/lib/pipeline/rte_port_in_action.h b/lib/pipeline/rte_port_in_action.h
index 9d17bae988..ee6cc59fae 100644
--- a/lib/pipeline/rte_port_in_action.h
+++ b/lib/pipeline/rte_port_in_action.h
@@ -164,18 +164,6 @@ struct rte_port_in_action_lb_params {
*/
struct rte_port_in_action_profile;
-/**
- * Input port action profile create.
- *
- * @param[in] socket_id
- * CPU socket ID for the internal data structures memory allocation.
- * @return
- * Input port action profile handle on success, NULL otherwise.
- */
-__rte_experimental
-struct rte_port_in_action_profile *
-rte_port_in_action_profile_create(uint32_t socket_id);
-
/**
* Input port action profile free.
*
@@ -189,6 +177,19 @@ __rte_experimental
int
rte_port_in_action_profile_free(struct rte_port_in_action_profile *profile);
+/**
+ * Input port action profile create.
+ *
+ * @param[in] socket_id
+ * CPU socket ID for the internal data structures memory allocation.
+ * @return
+ * Input port action profile handle on success, NULL otherwise.
+ */
+__rte_experimental
+struct rte_port_in_action_profile *
+rte_port_in_action_profile_create(uint32_t socket_id)
+ __rte_malloc __rte_dealloc(rte_port_in_action_profile_free, 1);
+
/**
* Input port action profile action register.
*
@@ -236,6 +237,19 @@ rte_port_in_action_profile_freeze(struct rte_port_in_action_profile *profile);
*/
struct rte_port_in_action;
+/**
+ * Input port action free.
+ *
+ * @param[in] action
+ * Handle to input port action object (needs to be valid).
+ * If action is NULL, no operation is performed.
+ * @return
+ * Always zero.
+ */
+__rte_experimental
+int
+rte_port_in_action_free(struct rte_port_in_action *action);
+
/**
* Input port action create.
*
@@ -252,21 +266,8 @@ struct rte_port_in_action;
*/
__rte_experimental
struct rte_port_in_action *
-rte_port_in_action_create(struct rte_port_in_action_profile *profile,
- uint32_t socket_id);
-
-/**
- * Input port action free.
- *
- * @param[in] action
- * Handle to input port action object (needs to be valid).
- * If action is NULL, no operation is performed.
- * @return
- * Always zero.
- */
-__rte_experimental
-int
-rte_port_in_action_free(struct rte_port_in_action *action);
+rte_port_in_action_create(struct rte_port_in_action_profile *profile, uint32_t socket_id)
+ __rte_malloc __rte_dealloc(rte_port_in_action_free, 1);
/**
* Input port params get.
diff --git a/lib/pipeline/rte_table_action.h b/lib/pipeline/rte_table_action.h
index 47a7bdfc01..e8b4d8b33d 100644
--- a/lib/pipeline/rte_table_action.h
+++ b/lib/pipeline/rte_table_action.h
@@ -54,6 +54,7 @@
#include <stdint.h>
+#include <rte_common.h>
#include <rte_compat.h>
#include <rte_ether.h>
#include <rte_ip6.h>
@@ -812,17 +813,6 @@ struct rte_table_action_decap_params {
*/
struct rte_table_action_profile;
-/**
- * Table action profile create.
- *
- * @param[in] common
- * Common action configuration.
- * @return
- * Table action profile handle on success, NULL otherwise.
- */
-__rte_experimental
-struct rte_table_action_profile *
-rte_table_action_profile_create(struct rte_table_action_common_config *common);
/**
* Table action profile free.
@@ -836,6 +826,19 @@ __rte_experimental
int
rte_table_action_profile_free(struct rte_table_action_profile *profile);
+/**
+ * Table action profile create.
+ *
+ * @param[in] common
+ * Common action configuration.
+ * @return
+ * Table action profile handle on success, NULL otherwise.
+ */
+__rte_experimental
+struct rte_table_action_profile *
+rte_table_action_profile_create(struct rte_table_action_common_config *common)
+ __rte_malloc __rte_dealloc(rte_table_action_profile_free, 1);
+
/**
* Table action profile action register.
*
@@ -881,6 +884,18 @@ rte_table_action_profile_freeze(struct rte_table_action_profile *profile);
*/
struct rte_table_action;
+/**
+ * Table action free.
+ *
+ * @param[in] action
+ * Handle to table action object (needs to be valid).
+ * @return
+ * Zero on success, non-zero error code otherwise.
+ */
+__rte_experimental
+int
+rte_table_action_free(struct rte_table_action *action);
+
/**
* Table action create.
*
@@ -898,20 +913,8 @@ struct rte_table_action;
*/
__rte_experimental
struct rte_table_action *
-rte_table_action_create(struct rte_table_action_profile *profile,
- uint32_t socket_id);
-
-/**
- * Table action free.
- *
- * @param[in] action
- * Handle to table action object (needs to be valid).
- * @return
- * Zero on success, non-zero error code otherwise.
- */
-__rte_experimental
-int
-rte_table_action_free(struct rte_table_action *action);
+rte_table_action_create(struct rte_table_action_profile *profile, uint32_t socket_id)
+ __rte_malloc __rte_dealloc(rte_table_action_free, 1);
/**
* Table action table params get.
--
2.45.2
More information about the dev
mailing list