[PATCH v6 03/15] net/xsc: add xsc mailbox

WanRenyong wanry at yunsilicon.com
Tue Jan 21 04:31:05 CET 2025


On 2025/1/21 2:19, Stephen Hemminger wrote:
> On Mon, 20 Jan 2025 19:14:37 +0800
> "WanRenyong" <wanry at yunsilicon.com> wrote:
>
>> +static struct xsc_cmdq_req_msg *
>> +xsc_cmdq_req_msg_alloc(struct xsc_dev *xdev, int len)
>> +{
>> +	struct xsc_cmdq_req_msg *msg;
>> +	struct xsc_cmdq_mbox *head = NULL;
>> +	int cmd_len, nb_mbox;
>> +
>> +	msg = (struct xsc_cmdq_req_msg *)malloc(sizeof(*msg));
> Malloc returns void *, so cast here is unnecessary in C
Thanks for your review.

I will address this issue and any similar issues elsewhere in the next 
version.

-- 
Best regards,
WanRenyong


More information about the dev mailing list