[RFC 0/7] Introduce FreeBSD macros for SAFE iteration
Stephen Hemminger
stephen at networkplumber.org
Mon Jan 27 19:03:54 CET 2025
This series adds common macros for safe iteration over lists.
It is a subset copy of the macros from FreeBSD that are
missing from the Linux header sys/queue.h
Chose this over several other options:
- let each driver define their own as needed.
One Intel driver got it wrong, others will as well.
- rename all the queue macros to RTE_XXX variants.
Seems like useless renaming and confusion.
- Several distros have libbsd package with the correct macros.
But adding yet another dependency to DPDK would be annoying
for something this basic.
There are more macros in FreeBSD header that could be useful,
but we can add those later as needed here.
Stephen Hemminger (7):
eal: add queue macro extensions from FreeBSD
net/qede: fix use after free
bus/fslmc: fix use after free
net/bnxt: fix use after free
net/iavf: replace local version of TAILQ_FOREACH_SAFE
vhost: replace open coded TAILQ_FOREACH_SAFE
raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 5 +-
drivers/net/bnxt/bnxt_filter.c | 8 +-
drivers/net/iavf/iavf_vchnl.c | 8 +-
drivers/net/qede/qede_ethdev.h | 3 +-
drivers/net/qede/qede_filter.c | 13 +-
drivers/raw/ifpga/base/opae_osdep.h | 1 +
lib/eal/include/meson.build | 3 +-
lib/eal/include/rte_queue.h | 174 +++++++++++++++++++++++
lib/vhost/socket.c | 11 +-
9 files changed, 193 insertions(+), 33 deletions(-)
create mode 100644 lib/eal/include/rte_queue.h
--
2.45.2
More information about the dev
mailing list