[PATCH 3/4] net/netvsc: log error on failure to switch data path
longli at linuxonhyperv.com
longli at linuxonhyperv.com
Tue Jan 28 02:35:05 CET 2025
From: Long Li <longli at microsoft.com>
There is no recovery code path if netvsc failed to switch data path.
Log an error in this case for troubleshooting.
Signed-off-by: Long Li <longli at microsoft.com>
---
drivers/net/netvsc/hn_vf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c
index 5d8058774d..4ff766ec8b 100644
--- a/drivers/net/netvsc/hn_vf.c
+++ b/drivers/net/netvsc/hn_vf.c
@@ -316,8 +316,9 @@ static void hn_vf_remove(struct hn_data *hv)
} else {
/* Stop incoming packets from arriving on VF */
ret = hn_nvs_set_datapath(hv, NVS_DATAPATH_SYNTHETIC);
- if (ret == 0)
- hv->vf_ctx.vf_vsc_switched = false;
+ if (ret)
+ PMD_DRV_LOG(ERR, "Failed to switch to synthetic");
+ hv->vf_ctx.vf_vsc_switched = false;
}
rte_rwlock_write_unlock(&hv->vf_lock);
}
--
2.34.1
More information about the dev
mailing list