[RFC PATCH 1/1] dts: add SUT cleanup to framework

Dean Marx dmarx at iol.unh.edu
Thu Jan 30 22:32:26 CET 2025


> My first question was why is there a need to pass all of dpdk_config through from here all the way to cleanup_sut()? Is it sufficient to extract dpdk_location from dpdk_config at the beginning here, and pass along just dpdk_location?

I can do that too if it's preferred, wasn't sure what the best way to
handle that was my apologies

> I understand the need for str or PurePath, but can you explain why None is included in the union?

I believe it was just so the linter wouldn't throw errors in the check
format script, but I can double check that.

> There was also discussion at the previous DTS meeting about appending the datetime to the dpdk artifacts when they're copied over to the SUT (a way to create artifact uniqueness). It's not really within the scope of this patchseries, but it wouldn't hurt for us to touch base - maybe you can do this next.

Yes, that's in progress currently but I've put it on the backburner
for now. Will send out a separate RFC for that sometime soon.

> Looks good to me overall. Once you submit the v2 I will leave a little time for other comments, otherwise I will merge.
>
> Thanks Dean.

Sounds good, I'll get that out asap


More information about the dev mailing list