[PATCH v3 09/18] stack: fix unaligned accesses on 128-bit

Morten Brørup mb at smartsharesystems.com
Tue Jul 8 17:41:46 CEST 2025


> From: David Marchand [mailto:david.marchand at redhat.com]
> Sent: Tuesday, 8 July 2025 14.28
> 
> Fixes: 3340202f5954 ("stack: add lock-free implementation")
> Cc: stable at dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> ---

> -	struct rte_stack_lf_head old_head;
> +	alignas(16) struct rte_stack_lf_head old_head;

I don't know if Bruce also commented on this one, like he did on patch 12/18; so at the risk of repeating something already mentioned...

If all uses of struct rte_stack_lf_head must be 16-byte aligned, better fix the root cause by aligning the type rather than every use of it.
Please add such a root cause fix to the 25.11 TODO list, like the alignment of the struct rte_mp_msg type.



More information about the dev mailing list