[PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function

[刘洁]

> -----原始邮件-----
> 发件人: "Stephen Hemminger" <stephen at networkplumber.org>
> 发送时间: 2025-07-10 00:09:30 (星期四)
> 收件人: "Jie Liu" <liujie5 at linkdatatechnology.com>
> 抄送: dev at dpdk.org
> 主题: Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function
> 
> On Wed,  9 Jul 2025 04:43:04 -0400
> Jie Liu <liujie5 at linkdatatechnology.com> wrote:
> 
> > +	RTE_ATOMIC(bool)link_thread_running;
> > +	RTE_ATOMIC(bool)is_stopping;
> 
> Despite what checkpatch says, need space here:
> 	RTE_ATOMIC(bool) is_stopping;
> 
> > +	rte_thread_t link_thread_tid;
> > +	rte_atomic32_t link_thread_running;
> 
> Don't use old rte atomics, instead use RTE_ATOMIC() consistently
> 
> > +	rte_atomic32_t is_stopping;
> > +	pthread_t link_thread_tid;
> 
> Two struct elements with same name, how does that work?
> 
> > +	bool is_stopped;

This will be fully revised in the 14th patch, so please don't worry.</liujie5 at linkdatatechnology.com></liujie5 at linkdatatechnology.com></stephen at networkplumber.org>