[PATCH] net/ice: fix assumption about tag placement order

David Marchand david.marchand at redhat.com
Thu Jul 17 10:19:24 CEST 2025


On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson
<bruce.richardson at intel.com> wrote:
>
> The specific placement of outer/inner VLAN tags in E810 and related NICs
> is configurable. Therefore, remove the assumption that if the L2Tag2
> field is filled in, that the L2Tag1 must also be. Instead, check the
> existing mbuf VLAN flags, and move tags and set flags as appropriate.
> This fixes an issue where, with QinQ packets with different Tag ethtypes
> (0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only
> having had one tag stripped.
>
> Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
> Cc: stable at dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

The ice code seems copy/pasted from i40e.
So I guess i40e is affected as well.


-- 
David Marchand



More information about the dev mailing list