[PATCH] devtools: forbid use of compiler pragmas

Thomas Monjalon thomas at monjalon.net
Mon Jul 21 15:26:13 CEST 2025


30/01/2025 09:52, David Marchand:
> On Thu, Jan 30, 2025 at 9:45 AM Morten Brørup <mb at smartsharesystems.com> wrote:
> >
> > > From: David Marchand [mailto:david.marchand at redhat.com]
> > > Sent: Thursday, 30 January 2025 09.38
> > >
> > > Using pragma must be prevented to avoid breaking builds with other
> > > compilers.
> > > Let EAL use them (like for abstraction macros).
> >
> > You are only allowing them in rte_common.h.
> > Do we need them elsewhere in EAL?
> > Not that I think so, but the patch description could be interpreted that way.
> 
> Ah yes, I forgot to update description afterwards.
> I can update when applying.
> 
> >
> > >
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > ---
> >
> > Good idea!
> >
> > Acked-by: Morten Brørup <mb at smartsharesystems.com>

Applied with updated commit log, thanks.




More information about the dev mailing list