[PATCH v2] app/test-cmdline: add test to Windows build

Andre Muezerie andremue at linux.microsoft.com
Mon Jul 21 20:18:32 CEST 2025


Header termios.h was not found on Windows, which was probably the
reason this test was originally excluded from the Windows build.
However, ir turns out this header is not needed for this test, so it
can be removed and then test can be added to the Windows build
without negative consequences.

Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
 app/test-cmdline/cmdline_test.c | 1 -
 app/test-cmdline/commands.c     | 1 -
 app/test-cmdline/meson.build    | 6 ------
 3 files changed, 8 deletions(-)

diff --git a/app/test-cmdline/cmdline_test.c b/app/test-cmdline/cmdline_test.c
index 89f4260cbf..21b4a4278d 100644
--- a/app/test-cmdline/cmdline_test.c
+++ b/app/test-cmdline/cmdline_test.c
@@ -8,7 +8,6 @@
 #include <stdarg.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <termios.h>
 #include <ctype.h>
 #include <sys/queue.h>
 
diff --git a/app/test-cmdline/commands.c b/app/test-cmdline/commands.c
index a13e1d1afd..62b4e5dfa7 100644
--- a/app/test-cmdline/commands.c
+++ b/app/test-cmdline/commands.c
@@ -4,7 +4,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <termios.h>
 #include <inttypes.h>
 
 #include <rte_common.h>
diff --git a/app/test-cmdline/meson.build b/app/test-cmdline/meson.build
index 6027f67919..9d0a9aeb6e 100644
--- a/app/test-cmdline/meson.build
+++ b/app/test-cmdline/meson.build
@@ -1,11 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
 sources = files('commands.c', 'cmdline_test.c')
 deps += 'cmdline'
-- 
2.50.1.vfs.0.0



More information about the dev mailing list