[PATCH] net/ice: revert count drop-all filter in Rx stats

Burakov, Anatoly anatoly.burakov at intel.com
Tue Oct 14 10:41:38 CEST 2025


On 10/14/2025 7:43 AM, Shaiq Wani wrote:
> This reverts commit af05f9e37153c53335938bcde2978a359c5f4efa
> 
> This patch caused testpmd to count packets not destined for our MAC
> even when promiscuous mode is off.This behaviour is inconsistent with
> other drivers and leads to incorrect Rx statistics.
> 
> Fixes: af05f9e ("net/ice: count drop-all filter in Rx stats")
> Cc: stable at dpdk.org

IIRC this change is still in next-net so no need for CC stable

> 
> Signed-off-by: Shaiq Wani <shaiq.wani at intel.com>
> ---
>   drivers/net/intel/ice/ice_ethdev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
> index a9a49cd924..9d0fbd2a5a 100644
> --- a/drivers/net/intel/ice/ice_ethdev.c
> +++ b/drivers/net/intel/ice/ice_ethdev.c
> @@ -6353,13 +6353,12 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>   
>   	stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
>   			  pf->main_vsi->eth_stats.rx_multicast +
> -			  ns->eth.rx_unknown_protocol +
>   			  pf->main_vsi->eth_stats.rx_broadcast -
>   			  pf->main_vsi->eth_stats.rx_discards;
>   	stats->opackets = ns->eth.tx_unicast +
>   			  ns->eth.tx_multicast +
>   			  ns->eth.tx_broadcast;
> -	stats->ibytes   = ns->eth.rx_bytes;
> +	stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
>   	stats->obytes   = ns->eth.tx_bytes;
>   	stats->oerrors  = ns->eth.tx_errors +
>   			  pf->main_vsi->eth_stats.tx_errors;


-- 
Thanks,
Anatoly


More information about the dev mailing list