[PATCH v6 5/7] app/testpmd: use space separator in dump commands
Thomas Monjalon
thomas at monjalon.net
Wed Oct 15 21:10:09 CEST 2025
15/10/2025 19:52, Stephen Hemminger:
> On Tue, 14 Oct 2025 14:33:38 +0200
> Thomas Monjalon <thomas at monjalon.net> wrote:
>
> > @@ -9099,7 +9123,6 @@ dump_struct_sizes(void)
> > #undef DUMP_SIZE
> > }
> >
> > -
> > /* Dump the socket memory statistics on console */
> > static void
> > dump_socket_mem(FILE *f)
> > @@ -9114,7 +9137,6 @@ dump_socket_mem(FILE *f)
> > static size_t last_allocs;
> > static size_t last_total;
> >
> > -
> > for (i = 0; i < RTE_MAX_NUMA_NODES; i++) {
> > if (rte_malloc_get_socket_stats(i, &socket_stats) ||
> > !socket_stats.heap_totalsz_bytes)
>
> Unrelated whitespace changes in patches are discouraged.
It is quite related given this patch is about dump commands,
including this dump_socket_mem().
But yes, no other lines are changed in this specific function.
Do you really think removing extra blank lines is bad in this case?
More information about the dev
mailing list