[PATCH v5 00/21] Wangxun new NIC support

[Zaiyu Wang]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Friday, October 17, 2025 12:59 AM
> To: Zaiyu Wang <zaiyuwang at trustnetic.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH v5 00/21] Wangxun new NIC support
> 
> On Thu, 16 Oct 2025 19:17:14 +0800
> Zaiyu Wang <zaiyuwang at trustnetic.com> wrote:
> 
> > We have released a new NIC series: Amber-Lite, with two models
> > supporting 10G/25G and 40G rates. Due to minimal hardware differences
> > from existing 10G NICs, it remains supported within the txgbe driver.
> >
> > ---
> > v5:
> >  - update txgbe guides, add more usage instructions
> >  - add a short summary into 25.11 release notes
> > ---
> >
> > Zaiyu Wang (21):
> >   net/txgbe: add basic information for Amber-Lite 25G/40G NICs
> >   net/txgbe: add new SW-FW mailbox interface
> >   net/txgbe: add identification support for new SFP/QSFP modules
> >   net/txgbe: rename raptor to sp for Sapphire-specific code
> >   net/txgbe: add basic link configuration for Amber-Lite NICs
> >   net/txgbe: add support for PHY configuration via SW-FW mailbox
> >   net/txgbe: add RX&TX support for Amber-Lite NICs
> >   net/txgbe: add hardware reset change for Amber-Lite NICs
> >   net/txgbe: add MAC reconfiguration to avoid packet loss
> >   net/txgbe: add TX head Write-Back mode for Amber-Lite NICs
> >   net/txgbe: add RX desc merge mode for Amber-Lite NICs
> >   net/txgbe: add FEC support for Amber-Lite 25G NICs
> >   net/txgbe: add GPIO configuration
> >   net/txgbe: disable unstable features
> >   net/txgbe: add support for TX laser enable/disable
> >   net/txgbe: add support for TX queue rate limiting
> >   net/txgbe: add support for getting PHY ID
> >   net/txgbe: add thermal sensor configuration for Amber-Lite NICs
> >   net/txgbe: add RSS for Amber-Lite NICs
> >   doc: update for txgbe guides
> >   doc: update release notes for Wangxun txgbe driver
> >
> >  doc/guides/nics/txgbe.rst                 |  31 +-
> >  doc/guides/rel_notes/release_25_11.rst    |   7 +
> >  drivers/net/txgbe/base/meson.build        |   2 +
> >  drivers/net/txgbe/base/txgbe_aml.c        | 354 ++++++++++++++++++++
> >  drivers/net/txgbe/base/txgbe_aml.h        |  22 ++
> >  drivers/net/txgbe/base/txgbe_aml40.c      | 160 +++++++++
> >  drivers/net/txgbe/base/txgbe_aml40.h      |  20 ++
> >  drivers/net/txgbe/base/txgbe_devids.h     |   9 +
> >  drivers/net/txgbe/base/txgbe_eeprom.c     |   7 +-
> >  drivers/net/txgbe/base/txgbe_eeprom.h     |   2 +
> >  drivers/net/txgbe/base/txgbe_hw.c         | 365 ++++++++++++++++----
> >  drivers/net/txgbe/base/txgbe_hw.h         |  15 +-
> >  drivers/net/txgbe/base/txgbe_mng.c        | 184 +++++++++-
> >  drivers/net/txgbe/base/txgbe_mng.h        |  34 +-
> >  drivers/net/txgbe/base/txgbe_osdep.h      |   2 +
> >  drivers/net/txgbe/base/txgbe_phy.c        | 127 ++++++-
> >  drivers/net/txgbe/base/txgbe_phy.h        |  24 ++
> >  drivers/net/txgbe/base/txgbe_regs.h       | 103 +++++-
> >  drivers/net/txgbe/base/txgbe_type.h       |  70 +++-
> >  drivers/net/txgbe/base/txgbe_vf.c         |   2 +-
> >  drivers/net/txgbe/txgbe_ethdev.c          | 390
> ++++++++++++++++++++--
> >  drivers/net/txgbe/txgbe_ethdev.h          |   2 +-
> >  drivers/net/txgbe/txgbe_ethdev_vf.c       |   2 +-
> >  drivers/net/txgbe/txgbe_flow.c            |   2 +-
> >  drivers/net/txgbe/txgbe_rxtx.c            | 203 ++++++++---
> >  drivers/net/txgbe/txgbe_rxtx.h            |   3 +
> >  drivers/net/txgbe/txgbe_rxtx_vec_common.h |  27 +-
> >  27 files changed, 1967 insertions(+), 202 deletions(-)  create mode
> > 100644 drivers/net/txgbe/base/txgbe_aml.c
> >  create mode 100644 drivers/net/txgbe/base/txgbe_aml.h
> >  create mode 100644 drivers/net/txgbe/base/txgbe_aml40.c
> >  create mode 100644 drivers/net/txgbe/base/txgbe_aml40.h
> >
> 
> Queued to next-net.
> I changed the git commit subject to conform to the restrictions imposed by
> check-git-log.sh. Max line length of 60 and prefer "Rx" over "RX"
> 
Thank you for queuing the patch and fixing the nits.
I'll pay more attention to such details in future submissions.