[PATCH v9 3/3] dts: add Rx Tx offload test suite

[Andrew Bailey]

Add mbuf_fast_free portion of rxtx offload testsuite from legacy dts
to next dts. The testsuite expects mbuf fast free to be enabled by
default and verifies configuration of this Tx offload capability.

Signed-off-by: Andrew Bailey <abailey at iol.unh.edu>
---
 doc/api/dts/tests.TestSuite_rx_tx_offload.rst |  8 +++++
 dts/tests/TestSuite_rx_tx_offload.py          | 35 +++++++++++--------
 2 files changed, 28 insertions(+), 15 deletions(-)
 create mode 100644 doc/api/dts/tests.TestSuite_rx_tx_offload.rst

diff --git a/doc/api/dts/tests.TestSuite_rx_tx_offload.rst b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
new file mode 100644
index 0000000000..27834a74da
--- /dev/null
+++ b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
@@ -0,0 +1,8 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+
+rx_tx_offload Test Suite
+========================
+
+.. automodule:: tests.TestSuite_rx_tx_offload
+   :members:
+   :show-inheritance:
diff --git a/dts/tests/TestSuite_rx_tx_offload.py b/dts/tests/TestSuite_rx_tx_offload.py
index 16e1b8cf93..0d0043122d 100644
--- a/dts/tests/TestSuite_rx_tx_offload.py
+++ b/dts/tests/TestSuite_rx_tx_offload.py
@@ -27,9 +27,8 @@ def _check_config(
         rxtx: RxTxLiteralSwitch,
         /,
         queue_offload: list[str | None] | None = None,
-        verify: bool = True,
     ) -> bool:
-        config: OffloadConfiguration = testpmd.get_offload_config(port_id, rxtx, verify)
+        config: OffloadConfiguration = testpmd.get_offload_config(port_id, rxtx)
         if config.port.name != port_offload:
             return False
 
@@ -40,7 +39,11 @@ def _check_config(
         return True
 
     def _set_all_queues_mbuf_fast_free(
-        self, testpmd: TestPmd, port_id: int, on: bool, num_queues: int, /, verify: bool = True
+        self,
+        testpmd: TestPmd,
+        port_id: int,
+        on: bool,
+        num_queues: int,
     ) -> None:
         for i in range(num_queues):
             testpmd.set_queue_mbuf_fast_free(on, port_id, i, verify)
@@ -61,25 +64,24 @@ def test_mbuf_fast_free_configuration_per_port(self) -> None:
             * Mbuf_fast_free can be configured on per port.
         """
         with TestPmd() as testpmd:
-            to_verify = True
             port_id = 0
             testpmd.start_all_ports()
 
             # Ensure MBUF_FAST_FREE is enabled by default and verify
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx"),
                 "MBUF_FAST_FREE disabled on port start.",
             )
             # disable MBUF_FAST_FREE per port and verify
-            testpmd.set_port_mbuf_fast_free(port_id, False, to_verify)
+            testpmd.set_port_mbuf_fast_free(port_id, False)
             verify(
-                self._check_config(testpmd, port_id, None, "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, None, "tx"),
                 "Failed to enable MBUF_FAST_FREE on port.",
             )
             # Enable MBUF_FAST_FREE per port and verify
-            testpmd.set_port_mbuf_fast_free(port_id, True, to_verify)
+            testpmd.set_port_mbuf_fast_free(port_id, True)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx"),
                 "Failed to disable MBUF_FAST_FREE on port.",
             )
 
@@ -99,7 +101,6 @@ def test_mbuf_fast_free_configuration_per_queue(self) -> None:
             * Mbuf_fast_free can be configured on per queue.
         """
         with TestPmd() as testpmd:
-            to_verify = True
             port_id = 0
             num_queues = 4
             queue_off: list[str | None] | None = [None] * num_queues
@@ -111,19 +112,23 @@ def test_mbuf_fast_free_configuration_per_queue(self) -> None:
             # Ensure mbuf_fast_free is enabled by default on port and queues
             verify(
                 self._check_config(
-                    testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on, verify=to_verify
+                    testpmd,
+                    port_id,
+                    "MBUF_FAST_FREE",
+                    "tx",
+                    queue_on,
                 ),
                 "MBUF_FAST_FREE disabled on queue start.",
             )
             # Disable mbuf_fast_free per queue and verify
-            self._set_all_queues_mbuf_fast_free(testpmd, port_id, False, num_queues, to_verify)
+            self._set_all_queues_mbuf_fast_free(testpmd, port_id, False, num_queues)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_off, to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_off),
                 "Failed to disable MBUF_FAST_FREE on all queues.",
             )
             # Disable mbuf_fast_free per queue and verify
-            self._set_all_queues_mbuf_fast_free(testpmd, port_id, True, num_queues, to_verify)
+            self._set_all_queues_mbuf_fast_free(testpmd, port_id, True, num_queues)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on, to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on),
                 "Failed to enable MBUF_FAST_FREE on all queues.",
             )
-- 
2.50.1