[PATCH] devtools: honor -n flag regardless of stdin state
Thomas Monjalon
thomas at monjalon.net
Thu Oct 23 16:51:54 CEST 2025
23/10/2025 16:33, Thomas Monjalon:
> 14/10/2025 09:43, Ali Alnubani:
> > The checkpatches.sh script was checking if stdin is a terminal before
> > honoring the -n flag, causing it to incorrectly attempt to read patches
> > from stdin when run without a TTY (e.g., in Jenkins/CI pipelines).
> >
> > Reorder the conditionals to check for the -n flag before checking stdin
> > state. This ensures the -n flag takes precedence and the script checks
> > git commits as intended.
> >
> > Signed-off-by: Ali Alnubani <alialnu at nvidia.com>
>
> Applied, thanks.
After a second thought, I did not push it
as I think we should improve the check to make
the option -r a priority as well.
Then the title would become "check patch from stdin only if nothing else".
More information about the dev
mailing list