[EXTERNAL] Re: [PATCH v8 1/1] ethdev: add support to provide link type
Sunil Kumar Kori
skori at marvell.com
Mon Sep 1 07:05:46 CEST 2025
> On Thu, 21 Aug 2025 11:02:33 +0530
> <skori at marvell.com> wrote:
>
> > From: Sunil Kumar Kori <skori at marvell.com>
> >
> > Adding link type parameter to provide the type of port like twisted
> > pair, fibre etc.
> >
> > Also added an API to convert the RTE_ETH_LINK_CONNECTOR_XXX to a
> > readable string.
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram at marvell.com>
> > Signed-off-by: Sunil Kumar Kori <skori at marvell.com>
>
> Looks good now. Would prefer that you settle on one term connector rather than
> mixing 'link type' and 'link connnector'
> in commit description and comments. Do you want me to make it consistent?
>
I replaced "link type" with connector at all the places as per knowledge. If you still see any reference of string "link_type"
Then please replace it with "connector".
> Please also provide release note with short concise summary and what user
> should expect as default until/unless drivers change it.
I will submit next version adding release note.
More information about the dev
mailing list