[RFC 2/4] devtools: recognize kernel trailer tags
Stephen Hemminger
stephen at networkplumber.org
Thu Apr 2 18:16:07 CEST 2026
Add Co-developed-by to the set of recognized attribution tags and
Closes: and Link: to the set of recognized relation tags. These
are standard Linux kernel trailers:
Co-developed-by: indicates a patch co-author (kernel requires
it be immediately followed by a Signed-off-by for that person).
Closes: URL pointing to a bug report being fixed.
Link: URL to a related mailing list discussion.
Also add explicit validation entries in the tag spelling check for
Cc:, Coverity issue:, and Bugzilla ID: which previously had no
format check (they were matched for ordering but any malformed
value would silently pass).
Exempt Closes: and Link: URLs from the 75-character body line
length limit, matching the existing exemption for Fixes: lines.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
devtools/check-git-log.sh | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 1e04bca01b..3775b1587f 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -55,8 +55,8 @@ stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut -d' ' -
# Use git's own trailer parser rather than hand-rolled regex.
# %(trailers:unfold) gives us exactly what git-interpret-trailers --parse sees.
tags=$(git log --format='%(trailers:unfold)' --reverse $range | grep -v '^$')
-bytag='\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by:'
-reltag='Coverity issue:\|Bugzilla ID:\|Fixes:\|Cc:'
+bytag='\(Reported\|Suggested\|Signed-off\|Co-developed\|Acked\|Reviewed\|Tested\)-by:'
+reltag='Coverity issue:\|Bugzilla ID:\|Fixes:\|Cc:\|Closes:\|Link:'
failure=false
@@ -149,6 +149,7 @@ bad=$(echo "$headlines" |
# check body lines length (75 max)
bad=$(echo "$bodylines" | grep -v '^Fixes:' |
+ grep -v '^Closes: https\?://' | grep -v '^Link: https\?://' |
awk 'length>75 {print}' |
sed 's,^,\t,')
[ -z "$bad" ] || { printf "Line too long:\n$bad\n" && failure=true;}
@@ -165,6 +166,11 @@ done | sed 's,^,\t,')
bad=$(echo "$tags" |
grep -v "^$bytag [^,]* <.*@.*>$" |
grep -v '^Fixes: [0-9a-f]\{7\}[0-9a-f]* (".*")$' |
+ grep -v '^Closes: https\?://.*' |
+ grep -v '^Link: https\?://.*' |
+ grep -v '^Cc: .*' |
+ grep -v '^Coverity issue: .*' |
+ grep -v '^Bugzilla ID: .*' |
sed 's,^.,\t&,')
[ -z "$bad" ] || { printf "Wrong tag:\n$bad\n" && failure=true;}
--
2.53.0
More information about the dev
mailing list