[RFC 4/4] devtools: demote tag ordering to warning

Stephen Hemminger stephen at networkplumber.org
Thu Apr 2 18:16:09 CEST 2026


The Linux kernel does not enforce a strict tag ordering via tooling.
Ordering is a convention, enforced socially by maintainers rather
than by checkpatch.pl.  The b4 tool has a configurable trailer-order
preference, but it is not mandatory.

Demote the tag ordering check from an error (which sets failure=true
and causes a non-zero exit) to a warning (printed but does not
affect the exit code).  This avoids rejecting patches that are
otherwise correct but happen to have Reviewed-by before Acked-by
or similar minor ordering differences.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 devtools/check-git-log.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 94cf68b926..5b621f5c8d 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -266,8 +266,7 @@ bad=$(for commit in $commits; do
 			chronological = 1;
 	 }'
 done)
-[ -z "$bad" ] || { printf "Wrong tag order: \n$bad\n"\
-	&& failure=true;}
+[ -z "$bad" ] || printf "WARNING: non-preferred tag order: \n$bad\n"
 
 # check required tag
 bad=$(for commit in $commits; do
-- 
2.53.0



More information about the dev mailing list