[PATCH v1 01/15] power/kvm_vm: enforce enabled lcore ID check
lihuisong (C)
lihuisong at huawei.com
Tue Apr 21 13:07:12 CEST 2026
On 4/17/2026 10:51 AM, lihuisong (C) wrote:
>
> On 4/16/2026 11:48 PM, Stephen Hemminger wrote:
>> On Thu, 16 Apr 2026 11:05:58 +0800
>> Huisong Li <lihuisong at huawei.com> wrote:
>>
>>> The locre ID in cpufreq power must be enabled core in application.
>> Spelling error, use checkpatch next time, it runs a spell checker.
>> Also run devtools/check-git-log there other issues in the commit
>> messages.
> Sorry for this.
> Yeah, I used checkpatch.sh and check-git-log.sh before sent out.
> But it didn't found this. I guess that because the "locre" is not a word.
>>> Use rte_lcore_is_enabled to verify lcore_id.
>>>
>>> Fixes: 6f987b594fa6 ("power: refactor core power management")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: Huisong Li <lihuisong at huawei.com>
>>> ---
>> The rte_lcore_is_enabled() will return false for service lcores.
>> Is this a bug or a feature here?
> My understanding is that the ROLE_RTE core is used to tasks on data
> plane and the ROLE_SERVICE core is used to periodic or control-plane
> tasks.
> Currently, power management in DPDK is mainly processed based on
> services on the data plane, like the usage in pmd_mgmt or l3fwd-power.
> However, the tasks on the service cores may also occupy 100% CPU.
> Therefore, power library or driver should be able to be work with
> these tasks.
> From this perspective, allowing the ROLE_SERVICE core to set power has
> the least impact on applications in this series.
> what do you think, Stephen?
Hi Sivaprasad,
Do you think we need to allow the role_service core to set cpufreq?
/Huisong
More information about the dev
mailing list