[PATCH v3 00/14] common/sfc_efx/base: fix code analysis issues
Stephen Hemminger
stephen at networkplumber.org
Sat Aug 15 17:44:27 CEST 2026
On Fri, 14 Aug 2026 16:54:24 +0400
Ivan Malov <ivan.malov at arknetworks.am> wrote:
> This series addresses code analysis defects in the
> common/sfc_efx/base library.
>
> The first four patches fix excessive stack consumption in
> MCDI helper functions, each exceeding 1 KB on-stack, by
> switching to heap-allocated payload buffers.
>
> The remaining ten patches correct SAL annotations, add
> assertions and bounds checks across netport and filter
> helpers to address uninitialised memory, buffer overrun,
> and potential dereference issues. The final patch widens
> loop variable types to address a CodeQL warning.
>
>
> v3:
>
> - addressed https://mails.dpdk.org/archives/dev/2026-August/343201.html
> -- patches 01-04: switched to EFX_MCDI_BUF_SIZE
> -- patch 05: replaced the unreachable NULL guard with
> EFSYS_ASSERT; corrected the commit message
> -- patches 09, 13: moved __success to the declaration line
> -- patch 11: added stride and count bounds check before the loop
> -- patch 13: documented the TECH_AUTO default behaviour
This all looks good, applied to next-net.
Still going through the later patches.
More information about the dev
mailing list