[PATCH v2 0/6] net/nfb: code cleanup

Stephen Hemminger stephen at networkplumber.org
Fri Jan 16 18:39:25 CET 2026


On Fri, 16 Jan 2026 10:42:20 +0100
Martin Spinler <spinler at cesnet.cz> wrote:

> Hi Stephen!
> 
> Thanks for quick review, my reaction to issues:
> 
> 1/6: The log message at line 543: fixed
> 2/6: Still missing NULL pointer checks: misleading,
>      dev->data->nb_rx_queues ensures the queue[i] was inited
> 4/6: uint16_t: applied, Doxygen comment: fixed
> 5/6: extra blank line: fixed
> Those fixes will be in v3.
> 
> 3,4,5,6/6: I think don't want to add Cc to stable, if you agree?
> 
> 
> Besides that series and 'net-nfb/rework to real multiport', I have
> another 3 series of a similar size that depends on those series: Native
> Queues, Metadata+Offloads, and Ethernet. To make the work easier, would
> you prefer to have it in one 19-commit series or should I to continue
> in 3 small series?
> 
> Thanks! Martin

Only cc stable if the driver was released in a stable version and
it is something that could be triggerable by bad input


More information about the dev mailing list