[PATCH v11 0/3] net/idpf: enable AVX2 for split queue Rx/Tx
Bruce Richardson
bruce.richardson at intel.com
Mon Jan 26 18:14:23 CET 2026
On Mon, Jan 05, 2026 at 11:52:54AM +0530, Shaiq Wani wrote:
> In case some CPUs don't support AVX512. Enable AVX2 for them to
> get better per-core performance.
>
> In the single queue model, the same descriptor queue is used by SW
> to post descriptors to the device and used by device to report completed
> descriptors to SW. While as the split queue model separates them into
> different queues for parallel processing and improved performance.
>
> v11:
> *Fixed indentation issues.
>
> v10:
> *Changed desc reading style in Rx path.
>
> v9:
> *Some minor fixes.
>
> v8:
> *Reworked the receive func to avoid race conditions in Rx path.
> *Removed unnecessary compiler barriers.
>
> v7:
> *Removed (char) casts, ifdef block as suggested.
> *Fixed indentation, line wrapping.
> *Did blind write of data to avoid branching.
> *changed desc building and writing order for Tx.
>
> v6:
> *used single load/store in splitq_recv_pkts function.
> *removed x86-specific intrinsics from common code.
>
> v5:
> *Fixed CI errors.
> *Used defined constants instead of numbers.
>
> v4:
> *moved splitq_rearm_common to a common location.
> *reduced duplication of code.
> *fixed splitq_recv_pkts function.
>
> v3:
> *Fixed some indentation issues.
> *Collapsed wrapper and core function into one.
> *Fixed some pointer casting and naming inconsistency issues.
>
> v2:
> *Fixed CI build related issues.
> *Rebased on top of idpf/cpfl rx path selection simplication patch.
>
>
>
> Shaiq Wani (3):
> net/idpf: enable AVX2 for split queue Rx
> net/idpf: enable AVX2 for split queue Tx
> doc: note on unsupported completion queue sharing
>
> doc/guides/nics/idpf.rst | 5 +
> drivers/net/intel/idpf/idpf_common_device.h | 1 +
> drivers/net/intel/idpf/idpf_common_rxtx.c | 59 ++++
> drivers/net/intel/idpf/idpf_common_rxtx.h | 8 +
> .../net/intel/idpf/idpf_common_rxtx_avx2.c | 317 +++++++++++++++++-
> .../net/intel/idpf/idpf_common_rxtx_avx512.c | 56 ----
> drivers/net/intel/idpf/idpf_rxtx.c | 9 +
> 7 files changed, 397 insertions(+), 58 deletions(-)
>
Beyond the AI review comments posted by Stephen, which does seem to flag
some issues that could do with being addressed, this set (mainly patch 2)
also needs a rebase to apply cleanly on top of latest next-net-intel tree.
It's missing support for the new Tx path selection logic.
Also, it would be good to have a release note entry for the new AVX2 code
paths added in either patch 1 or patch 2.
Thanks,
/Bruce
More information about the dev
mailing list