[REVIEW] net/nbl: improve exception handling for the mailbox
Stephen Hemminger
stephen at networkplumber.org
Mon Jan 26 19:28:46 CET 2026
On Mon, 26 Jan 2026 10:18:38 -0800
Stephen Hemminger <stephen at networkplumber.org> wrote:
> ### Code Review
> **Warning**: Missing NULL checks before rte_memzone_free()
> ```c
> rte_free(tx_ring->tx_entry);
> rte_memzone_free(tx_ring->net_hdr_mz); // Could be NULL if setup failed
> rte_memzone_free(tx_ring->desc_mz); // Could be NULL if setup failed
> ```
> While rte_memzone_free() handles NULL, this is not documented behavior. Better to check explicitly or document assumption.
Ignore this feedback. It indicates missing comments in rte_memzone, not your problem
More information about the dev
mailing list