[PATCH v5] dts: report dut/NIC info during DTS run
Koushik Bhargav Nimoji
knimoji at iol.unh.edu
Thu Jul 9 15:47:10 CEST 2026
On Wed, Jul 8, 2026 at 9:05 PM Patrick Robb <patrickrobb1997 at gmail.com>
wrote:
> Actually, please see the AI code review of this patch. Specifically, this
> comment looks correct to me. What are your thoughts?
>
> **File:** `dts/framework/testbed_model/linux_session.py`, line 228
>
> The code checks `lshw_result.return_code != 0 and lshw_result.stdout ==
> ""` but the logic is incorrect. If the command fails, you should raise an
> error. The `and` should likely be `or`:
>
This is definitely a valid issue, I will send out a patch fixing this
shortly.
>
> Please read through the other suggestions too. There is some fluff but
> also some good advice.
>
For sure, I will include changes from those suggestions in the subsequent
patch as well.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20260709/b0a1b21f/attachment.htm>
More information about the dev
mailing list