[PATCH v4 1/4] dma/ae4dma: introduce AMD AE4DMA DMA PMD

[Raghavendra Ningoji]

On Mon, 7 Jul 2026 at 06:54, fengchengwen <fengchengwen at huawei.com> wrote:
>
> > +#define AE4DMA_BIT(nr)			(1UL << (nr))
>
> Why not use RTE_BIT32() in rte_bitops.h which already included ?

Good point. The custom AE4DMA_BIT macro is removed in v5 and the
DWORD0 control-bit defines now use RTE_BIT32() directly
(rte_bitops.h is already included).

> > +#define AE4DMA_DWORD0_SOURCE_MEMEORY_TYPE_IOMEMORY  (1<<6)
>
> How about use RTE_BIT32(6) ?

Done. Both the destination and source IOMEMORY defines now use
RTE_BIT32(4) / RTE_BIT32(6) instead of open-coded shifts.

Thanks,
Raghavendra