[PATCH v2 3/3] net/tap: use bool for boolean flags
Maxime Leroy
maxime at leroys.fr
Mon Jul 20 14:06:59 CEST 2026
persist, flow_init and flow_isolate only ever hold true or false but were
declared as int. Use bool, consistent with the interrupt-mode flags added
in this series and with common DPDK practice.
Signed-off-by: Maxime Leroy <maxime at leroys.fr>
---
drivers/net/tap/rte_eth_tap.h | 6 +++---
drivers/net/tap/tap_flow.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h
index aae9eea510..80419aad8c 100644
--- a/drivers/net/tap/rte_eth_tap.h
+++ b/drivers/net/tap/rte_eth_tap.h
@@ -72,7 +72,7 @@ struct pmd_internals {
char remote_iface[IFNAMSIZ]; /* Remote netdevice name */
char name[IFNAMSIZ]; /* Internal Tap device name */
int type; /* Type field - TUN|TAP */
- int persist; /* 1 if keep link up, else 0 */
+ bool persist; /* 1 if keep link up, else 0 */
struct rte_ether_addr eth_addr; /* Mac address of the device port */
struct rte_ether_addr *mc_addrs; /* multicast address list */
uint32_t nb_mc_addrs; /* multicast address count */
@@ -82,8 +82,8 @@ struct pmd_internals {
int nlsk_fd; /* Netlink socket fd */
#ifdef HAVE_TCA_FLOWER
- int flow_init; /* 1 if qdiscs were created */
- int flow_isolate; /* 1 if flow isolation is enabled */
+ bool flow_init; /* 1 if qdiscs were created */
+ bool flow_isolate; /* 1 if flow isolation is enabled */
struct tap_rss *rss; /* BPF program */
diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
index a9d8e09562..a0ffb35bdd 100644
--- a/drivers/net/tap/tap_flow.c
+++ b/drivers/net/tap/tap_flow.c
@@ -1521,7 +1521,7 @@ tap_flow_isolate(struct rte_eth_dev *dev,
}
return 0;
error:
- pmd->flow_isolate = 0;
+ pmd->flow_isolate = false;
return rte_flow_error_set(
error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
"TC rule creation failed");
@@ -1914,7 +1914,7 @@ tap_flow_init(struct pmd_internals *pmd)
return -1;
}
- pmd->flow_init = 1;
+ pmd->flow_init = true;
return 0;
}
--
2.43.0
More information about the dev
mailing list