[PATCH 2/3] net/gve: remove unnecessary check for NULL

Stephen Hemminger stephen at networkplumber.org
Tue Jul 28 16:11:44 CEST 2026


Checking for NULL before calling rte_free is unnecessary.
Found by cocci/nullfree.cocci script.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/gve/gve_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/gve/gve_rx.c b/drivers/net/gve/gve_rx.c
index 567b82d020..932293ddad 100644
--- a/drivers/net/gve/gve_rx.c
+++ b/drivers/net/gve/gve_rx.c
@@ -205,8 +205,9 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		if (gve_rx(rxq, rxd, rx_id)) {
 			if (!ctx->drop_pkt)
 				rx_pkts[nb_rx++] = ctx->mbuf_head;
-			else if (ctx->mbuf_head != NULL)
+			else {
 				rte_pktmbuf_free(ctx->mbuf_head);
+			}
 			rxq->nb_avail += ctx->total_frags;
 			gve_rx_ctx_clear(ctx);
 		}
-- 
2.53.0



More information about the dev mailing list