[PATCH 1/2] net/sxe2: replace memcpy with structure assignment
Stephen Hemminger
stephen at networkplumber.org
Tue Jul 28 16:37:59 CEST 2026
When possible prefer structure assigment over untyped memcpy.
Found by cocci/struct-assign.cocci script.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/sxe2/sxe2_flow.c | 7 +++----
drivers/net/sxe2/sxe2_ipsec.c | 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/sxe2/sxe2_flow.c b/drivers/net/sxe2/sxe2_flow.c
index 63cfc36968..6c2e743f30 100644
--- a/drivers/net/sxe2/sxe2_flow.c
+++ b/drivers/net/sxe2/sxe2_flow.c
@@ -416,7 +416,7 @@ static int32_t sxe2_flow_src_split_proc(struct rte_eth_dev *dev,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(flow_new, flow, sizeof(struct sxe2_flow));
+ *flow_new = *flow;
TAILQ_INSERT_TAIL(sxe2_flow_list, flow_new, next);
flow_new->meta.flow_src_vsi =
flow_src_vsi[SXE2_MAX_DRV_TYPE_DPDK][idx];
@@ -437,7 +437,7 @@ static int32_t sxe2_flow_src_split_proc(struct rte_eth_dev *dev,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(flow_new, flow, sizeof(struct sxe2_flow));
+ *flow_new = *flow;
TAILQ_INSERT_TAIL(sxe2_flow_list, flow_new, next);
flow_new->meta.flow_src_vsi =
flow_src_vsi[SXE2_MAX_DRV_TYPE_KERNEL][idx];
@@ -697,8 +697,7 @@ static int32_t sxe2_flow_tunnel_split_proc(struct rte_eth_dev *dev __rte_unused,
ret = -ENOMEM;
goto l_end;
}
- rte_memcpy(sxe2_flow_new, sxe2_flow_exist,
- sizeof(struct sxe2_flow));
+ *sxe2_flow_new = *sxe2_flow_exist;
pattern = &sxe2_flow_new->pattern_outer;
sxe2_flow_new->meta.tunnel_type =
SXE2_FLOW_TUNNEL_TYPE_GRE;
diff --git a/drivers/net/sxe2/sxe2_ipsec.c b/drivers/net/sxe2/sxe2_ipsec.c
index e783a51b85..81cf250fd2 100644
--- a/drivers/net/sxe2/sxe2_ipsec.c
+++ b/drivers/net/sxe2/sxe2_ipsec.c
@@ -1159,7 +1159,7 @@ int sxe2_ipsec_pkt_metadata_set(void *device, struct rte_security_session *sessi
md = RTE_MBUF_DYNFIELD(m, sxe2_sctx->ipsec_ctx.md_offset, struct sxe2_ipsec_pkt_metadata *);
- memcpy(md, &sxe2_sess->pkt_metadata_template, sizeof(struct sxe2_ipsec_pkt_metadata));
+ *md = sxe2_sess->pkt_metadata_template;
md->esp_head_offset = offset;
PMD_LOG_INFO(DRV, "ipsec metadata set, offset:%u, said:%u, mode:%u, algo:%u.", offset,
--
2.53.0
More information about the dev
mailing list