Re: [PATCH] net/bnxt: fix memset size mismatch in Tx queue start

[Денис Люлин]

Kindly reminder
Sorry, But nobody has reviewed my patch on Patchwork https://patches.dpdk.org/project/dpdk/patch/20260416090252.2211405-1-lyulin.2003@mail.ru/
Could you please review this?

> 
> On Thu, Apr 16, 2026 at 5:03 AM Denis Lyulin <lyulin.2003 at mail.ru> wrote:
> 
>> When the tx_queue is started, previous stats are reset.
>> For tpa_v2 and P7, extended stats structure is used:
>> `struct bnxt_ring_stats_ext`, so passing wrong size to memset
>> makes not all stats to be reset. This commit sets correct size of
>> the structure passed to memset when zeroing-out previous stats.
>> 
>> Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")
>> Cc: shuanglin.wang at broadcom.com
>> Cc: stable at dpdk.org
>> 
>> Signed-off-by: Denis Lyulin <lyulin.2003 at mail.ru>
> 
> 
> Acked-by: Kishore Padmanabha <kishore.padmanabha at broadcom.com>
> 
>> ---
>> drivers/net/bnxt/bnxt_txr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
>> index 27758898b0..b6ad37f872 100644
>> --- a/drivers/net/bnxt/bnxt_txr.c
>> +++ b/drivers/net/bnxt/bnxt_txr.c
>> @@ -729,7 +729,7 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev,
>> uint16_t tx_queue_id)
>> */
>> if (BNXT_TPA_V2_P7(bp))
>> memset(&bp->prev_tx_ring_stats_ext[tx_queue_id], 0,
>> -                      sizeof(struct bnxt_ring_stats));
>> +                      sizeof(struct bnxt_ring_stats_ext));
>> else
>> memset(&bp->prev_tx_ring_stats[tx_queue_id], 0,
>> sizeof(struct bnxt_ring_stats));
>> --
>> 2.34.1
>> 
> 
> 
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20260723/560ebc8b/attachment-0001.htm>