[PATCH] power: fix duplicated typedef for setting uncore freq

lihuisong (C) lihuisong at huawei.com
Wed Jun 10 03:10:34 CEST 2026


Kindly ping for review.

On 5/7/2026 7:27 PM, Huisong Li wrote:
> Remove a duplicated rte_power_set_uncore_freq_t definition.
> And this ops is intended to set any available uncore frequency instead
> of minimum and maximum one.
>
> Fixes: ebe99d351a3f ("power: refactor uncore power management")
> Cc: stable at dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong at huawei.com>
> ---
>   lib/power/power_uncore_ops.h | 24 +-----------------------
>   1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/lib/power/power_uncore_ops.h b/lib/power/power_uncore_ops.h
> index 783860ee5b..025a55cb97 100644
> --- a/lib/power/power_uncore_ops.h
> +++ b/lib/power/power_uncore_ops.h
> @@ -76,8 +76,7 @@ typedef int (*rte_power_uncore_exit_t)(unsigned int pkg, unsigned int die);
>   typedef uint32_t (*rte_power_get_uncore_freq_t)(unsigned int pkg, unsigned int die);
>   
>   /**
> - * Set minimum and maximum uncore frequency for specified die on a package
> - * to specified index value.
> + * Set uncore frequency for specified die on a package to specified index value.
>    * It should be protected outside of this function for threadsafe.
>    *
>    * This function should NOT be called in the fast path.
> @@ -98,27 +97,6 @@ typedef uint32_t (*rte_power_get_uncore_freq_t)(unsigned int pkg, unsigned int d
>    */
>   typedef int (*rte_power_set_uncore_freq_t)(unsigned int pkg, unsigned int die, uint32_t index);
>   
> -/**
> - * Return the list length of available frequencies in the index array.
> - *
> - * This function should NOT be called in the fast path.
> - *
> - * @param pkg
> - *  Package number.
> - *  Each physical CPU in a system is referred to as a package.
> - * @param die
> - *  Die number.
> - *  Each package can have several dies connected together via the uncore mesh.
> - * @param index
> - *  The index of available frequencies.
> - *
> - * @return
> - *  - 1 on success with frequency changed.
> - *  - 0 on success without frequency changed.
> - *  - Negative on error.
> - */
> -typedef int (*rte_power_set_uncore_freq_t)(unsigned int pkg, unsigned int die, uint32_t index);
> -
>   /**
>    * Return the list length of available frequencies in the index array.
>    *


More information about the dev mailing list