[PATCH v8 13/21] net/txgbe: fix link stability for 40G NIC

Stephen Hemminger stephen at networkplumber.org
Wed Jun 17 17:55:22 CEST 2026


On Wed, 17 Jun 2026 16:13:00 +0800
Zaiyu Wang <zaiyuwang at trustnetic.com> wrote:

> +	/* CMS Config Master */
> +	addr  = E56G_CMS_ANA_OVRDVAL_7_ADDR;
> +	rdata = rd32_ephy(hw, addr);
> +	((E56G_CMS_ANA_OVRDVAL_7 *)&rdata)->ana_lcpll_lf_vco_swing_ctrl_i = 0xf;
> +	wr32_ephy(hw, addr, rdata);
> +

DPDK has replaced all use of the terms master/slave with alternative words.
This gets flagged by check patch. Please consider other alternatives.


WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#210: FILE: drivers/net/txgbe/base/txgbe_e56.c:181:
+	/* CMS Config Master */
 	              ^^^^^^

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#231: FILE: drivers/net/txgbe/base/txgbe_e56.c:202:
+	/* TXS Config Master */
 	              ^^^^^^

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#267: FILE: drivers/net/txgbe/base/txgbe_e56.c:238:
+	/* RXS Config master */
 	              ^^^^^^

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#484: FILE: drivers/net/txgbe/base/txgbe_e56.c:455:
+	/* PDIG Config master */
 	               ^^^^^^



More information about the dev mailing list