[PATCH v8 12/21] net/txgbe: fix link stability for 25G NIC

[Zaiyu Wang]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday, June 17, 2026 11:54 PM
> To: Zaiyu Wang <zaiyuwang at trustnetic.com>; Zaiyu Wang <zaiyuwang at trustnetic.com>
> Cc: dev at dpdk.org; stable at dpdk.org; Jiawen Wu <jiawenwu at trustnetic.com>; dev at dpdk.org;
> stable at dpdk.org; Jiawen Wu <jiawenwu at trustnetic.com>
> Subject: Re: [PATCH v8 12/21] net/txgbe: fix link stability for 25G NIC
> 
> On Wed, 17 Jun 2026 16:12:59 +0800
> Zaiyu Wang <zaiyuwang at trustnetic.com> wrote:
> 
> > +void
> > +set_fields_e56(unsigned int *src_data, unsigned int bit_high,
> > +	       unsigned int bit_low, unsigned int set_value) {
> 
> Function could be static here?

Hi Stephen,
Thanks for your time. This function is used in both txgbe_e56.c (for general PHY
configuration) and txgbe_e56_bp.c (for backplane mode configuration). Therefore, making it
static would not be feasible?
I have also fixed the other issues you pointed out, including the spelling corrections,
replacing tabs with spaces in log messages, and removing the term "master" from comments.

Best regards,
Zaiyu