[PATCH 04/17] crypto/scheduler: replace strncpy with strlcpy

[Bruce Richardson]

On Tue, Jun 23, 2026 at 05:51:34PM +0100, Bruce Richardson wrote:
> Replace strncpy() with safer strlcpy() which always null-terminates.
> 
> Fixes: 85b00824aeef ("crypto/scheduler: rename slave to worker")

Correction, this is not the introducer commit. Instead it's:

Fixes: 50e14527b9d1 ("crypto/scheduler: improve parameters parsing")


> Cc: stable at dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c
> index 95ce893f05..ceaefa329b 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd.c
> @@ -229,10 +229,10 @@ cryptodev_scheduler_create(const char *name,
>  			return -ENOMEM;
>  		}
>  
> -		strncpy(sched_ctx->init_worker_names[
> +		strlcpy(sched_ctx->init_worker_names[
>  					sched_ctx->nb_init_workers],
>  				init_params->worker_names[i],
> -				RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1);
> +				RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN);
>  
>  		sched_ctx->nb_init_workers++;
>  	}
> @@ -443,8 +443,8 @@ parse_worker_arg(const char *key __rte_unused,
>  		return -ENOMEM;
>  	}
>  
> -	strncpy(param->worker_names[param->nb_workers++], value,
> -			RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1);
> +	strlcpy(param->worker_names[param->nb_workers++], value,
> +			RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN);
>  
>  	return 0;
>  }
> -- 
> 2.53.0
>